Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#67 closed task (fixed)

Move result_code from analysis to generation

Reported by: dagss Owned by: robertwb
Priority: major Milestone: 0.10
Component: Code Generation Keywords: design internal
Cc:

Description

In Pyrex, rather than the result_code being filled in at analysis time, there's a result() method being called during code generation. Moving filling ; then the result temp can be allocated using CodeWriter and so on.

See Greg Ewing's posts in http://thread.gmane.org/gmane.comp.python.cython.devel/2390 this thread.

A lot of things are blocked by this:

  • Complex numbers in buffers without a lot of changes/workarounds (#56)
  • Closures and generators were off to a good start but where also blocked by this.

My personal opinion is that the workarounds will only pile up, while a change like this could potentially be done without too much trouble and would make it possible to start streamlining some code (especially stop worrying about figuring out workarounds for new code).

Change History (7)

comment:1 Changed 6 years ago by dagss

  • Summary changed from Move generation of result_code string from to Move result_code string from analysis to generation

comment:2 Changed 6 years ago by dagss

  • Summary changed from Move result_code string from analysis to generation to Move result_code from analysis to generation

comment:3 Changed 6 years ago by dagss

The relevant Pyrex commit is here:

http://hg.cython.org/pyrex/rev/da6e97bb7e6d

comment:4 Changed 6 years ago by dagss

  • Owner changed from somebody to dagss
  • Status changed from new to assigned

comment:5 Changed 6 years ago by dagss

  • Owner changed from dagss to robertwb
  • Status changed from assigned to new

comment:6 Changed 6 years ago by robertwb

  • Milestone changed from wishlist to 0.9.8.2
  • Resolution set to fixed
  • Status changed from new to closed

comment:7 Changed 6 years ago by robertwb

Note that temp allocation is still done in the analysis phase, see #77 for moving it to code generation.

Note: See TracTickets for help on using tickets.