Opened 6 years ago

Closed 5 years ago

#273 closed defect (invalid)

nogil check for usage of new temps

Reported by: dagss Owned by: dagss
Priority: major Milestone: 0.11.2
Component: Parsing Keywords:
Cc:

Description

In ModuleNode?.py, around line 1350, there used to be a check for whether Python temporaries were used in functions declared nogil. This was not implemented for the new temp system (so likely a bug in 0.11 here).

I haven't checked whether this is a problem since the last gil refactoring. At any rate the GIL check should probably be moved to the new gil checker transform instead.

I'm also thinking that perhaps checking for the type of the temps is a bit "indirect" way of doing things, and perhaps it is more robust to simply filter the allowed operations in a function.

Change History (9)

comment:1 Changed 6 years ago by dagss

See also #205. And, to some degree, #210.

comment:2 Changed 6 years ago by dagss

It is Nodes.py:1396

comment:3 Changed 6 years ago by robertwb

  • Milestone changed from 0.11.1 to 0.11.2

comment:4 Changed 6 years ago by scoder

Is this really a problem? What operations can there be that allocate a Python temp but do not require the GIL themselves?

comment:5 Changed 6 years ago by dagss

Basically I was just assuming that the check existed there for a reason (and decided to make a note rather than forget about it).

But it may be that we should just close this as invalid and count on any such strange cases to show up sometime and be handled in a more proper way.

comment:6 Changed 6 years ago by dagss

  • Resolution set to invalid
  • Status changed from new to closed

See Stefan's comment.

comment:7 Changed 5 years ago by dagss

  • Resolution invalid deleted
  • Status changed from closed to reopened

comment:8 Changed 5 years ago by dagss

  • Owner changed from somebody to dagss
  • Status changed from reopened to new

comment:9 Changed 5 years ago by dagss

  • Resolution set to invalid
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.