Ticket #67 (closed task: fixed)

Opened 4 months ago

Last modified 3 months ago

Move result_code from analysis to generation

Reported by: dagss Assigned to: robertwb
Priority: major Milestone: 0.10
Component: Code Generation Version:
Keywords: design internal Cc:

Description

In Pyrex, rather than the result_code being filled in at analysis time, there's a result() method being called during code generation. Moving filling ; then the result temp can be allocated using CodeWriter and so on.

See Greg Ewing's posts in [this thread].

A lot of things are blocked by this:

  • Complex numbers in buffers without a lot of changes/workarounds (#56)
  • Closures and generators were off to a good start but where also blocked by this.

My personal opinion is that the workarounds will only pile up, while a change like this could potentially be done without too much trouble and would make it possible to start streamlining some code (especially stop worrying about figuring out workarounds for new code).

Change History

09/05/2008 03:41:23 AM changed by dagss

  • summary changed from Move generation of result_code string from to Move result_code string from analysis to generation.

09/05/2008 03:41:39 AM changed by dagss

  • summary changed from Move result_code string from analysis to generation to Move result_code from analysis to generation.

09/05/2008 04:55:35 AM changed by dagss

The relevant Pyrex commit is here:

http://hg.cython.org/pyrex/rev/da6e97bb7e6d

09/05/2008 09:49:02 AM changed by dagss

  • owner changed from somebody to dagss.
  • status changed from new to assigned.

09/18/2008 02:15:26 AM changed by dagss

  • owner changed from dagss to robertwb.
  • status changed from assigned to new.

09/23/2008 02:00:27 PM changed by robertwb

  • status changed from new to closed.
  • resolution set to fixed.
  • milestone changed from wishlist to 0.9.8.2.

09/23/2008 02:01:52 PM changed by robertwb

Note that temp allocation is still done in the analysis phase, see #77 for moving it to code generation.