Ticket #147 (closed defect: fixed)

Opened 6 years ago

Last modified 3 months ago

BoolBinopNode doesn't reuse temps

Reported by: dagss Owned by: scoder
Priority: minor Milestone: 0.21
Component: Code Generation Keywords:
Cc:

Description (last modified by scoder) (diff)

Blocked by #77.

Before, BoolBinopNode was pretty smart about only using one temp, and reuse it for its children. In the transition phase with old and new temp ExprNodes mixed as children, this is not possible without serious effort. Once #77 is fixed, one could have a look at putting things back in place so that the extra C assignments aren't needed.

It is a pretty minor issue though, as no INCREF/DECREFs are involved, only the number of declared variables.

It is entirely possible to WONTFIX this ticket, but if so, please go over and clean out the comments left there now.

Change History

Changed 3 months ago by scoder

  • owner changed from somebody to scoder
  • status changed from new to assigned
  • description modified (diff)

Changed 3 months ago by scoder

  • status changed from assigned to closed
  • resolution set to fixed
  • description modified (diff)

Changed 3 months ago by scoder

  • milestone changed from wishlist to 0.21
Note: See TracTickets for help on using tickets.